Skip to content

Add tests to ensure native setters are called exactly once #816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2017
Merged

Add tests to ensure native setters are called exactly once #816

merged 1 commit into from
Oct 18, 2017

Conversation

PanayotCankov
Copy link
Contributor

when components are instantiated

Depends on NativeScript/NativeScript#4227
Before that commit native setters for background in iOS are called about 12 times.

@PanayotCankov PanayotCankov requested review from vakrilov and sis0k0 May 23, 2017 07:41
@PanayotCankov PanayotCankov force-pushed the add-test-for-native-setters branch 2 times, most recently from 4154c35 to a1b794b Compare May 23, 2017 07:46
@vakrilov
Copy link
Contributor

run ci

@PanayotCankov PanayotCankov force-pushed the add-test-for-native-setters branch from d86d350 to 80d1c2a Compare June 20, 2017 08:47
@SvetoslavTsenov
Copy link
Contributor

run ci

@SvetoslavTsenov
Copy link
Contributor

@PanayotCankov, can you try to rebase again

@sis0k0 sis0k0 added this to the 3.2 TBD milestone Jul 5, 2017
@dtopuzov
Copy link
Contributor

run ci

@vakrilov vakrilov force-pushed the add-test-for-native-setters branch from 80d1c2a to 56131d8 Compare October 11, 2017 06:16
@ghost ghost assigned vakrilov Oct 11, 2017
@ghost ghost added the in progress label Oct 11, 2017
@vakrilov vakrilov modified the milestones: 4.4, 4.x (TBD) Oct 11, 2017
@vchimev
Copy link
Contributor

vchimev commented Oct 17, 2017

run ci

@vchimev vchimev merged commit e589401 into master Oct 18, 2017
@ghost ghost removed the in progress label Oct 18, 2017
@vchimev vchimev deleted the add-test-for-native-setters branch October 18, 2017 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vakrilov vakrilov vakrilov approved these changes

@sis0k0 sis0k0 sis0k0 approved these changes

Assignees

@vakrilov vakrilov

Labels
None yet
Projects
None yet
Milestone
5.x (TBD)
Development

Successfully merging this pull request may close these issues.
6 participants
@PanayotCankov @vakrilov @SvetoslavTsenov @dtopuzov @vchimev @sis0k0